Minor cleanup in compute_overlap #46
Conversation
This removes Healpy from the script and uses the high-level astropy-healpix API instead.
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 26.63% 26.74% +0.10%
==========================================
Files 28 28
Lines 1359 1350 -9
==========================================
- Hits 362 361 -1
+ Misses 997 989 -8
Continue to review full report at Codecov.
|
|
Looks like it is failing lint. This was just a quick cross-check for me, the whole function can be removed. |
I think the lint errors should be fixed now.
It can? It's not dead code, it's toggled by the |
|
You are computing field overlap elsewhere no? |
I'm not sure what you mean. The overlap is accounted for in the objective function, so I never directly calculate it. Do you need it for something? |
|
Basically if someone wants to check quickly what overlap their grid has, it is nice to be able to easily check. |
I see. Well, I don't want to push you to remove it, if it is useful, but it does currently have nonsensical units, which should be fixed. |
|
Sounds good to me. |
This removes Healpy from the script and uses the high-level astropy-healpix API instead.
I don't understand what the
compute_overlapfunction does. It looks like it is computing the area of largest overlap between the first 100 tiles and the rest of the tiles. However, it is multiply the number of pixels in the overlap by the pixel linear resolution in arc minutes, which does not make any dimensional sense. The number of pixels in the overlap is a measure of area.