Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make component instance names qualified in topology c++ code gen and JSON dictionary #470

Merged
merged 28 commits into from
Aug 14, 2024

Conversation

jwest115
Copy link
Collaborator

  • Updated component instance names so they are fully qualified
  • Updated component instance names to use C++ qualification (rather than underscores)
  • Refactored C++ code gen to use component instance qualified names rather than short names
    • Change also applied to topology config objects, constants, and helper functions for consistency
  • Updated C++ code gen so component instances are defined inside their own namespaces
  • Regenerated reference test files and updated fpp test files to match these changes

Closes #349

@jwest115 jwest115 requested a review from bocchino July 17, 2024 22:58
@jwest115
Copy link
Collaborator Author

After talking to @thomas-bc, this change will require an update to fprime-gds

Copy link
Contributor

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the loaders, we parse the qualified names to infer name of component and channel/event/command
Logic will need to be adapted

https://github.com/nasa/fprime-gds/tree/devel/src/fprime_gds/common/loaders

@jwest115
Copy link
Collaborator Author

Created nasa/fprime#2813 to track the GDS update, will work this in before we merge anything on the FPP side.

Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bocchino bocchino merged commit 63a4a7e into nasa:main Aug 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++ code gen, dictionary] Make instance names more consistent
3 participants