Refactor containers iteration for performance

[v1k1nghawk]

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

---

Change Description

• Refactor iterating over containers
• Remove trailing whitespaces

Rationale

• Performance optimization
• Clean code

Future Work

None

[LeStarch]

@ThibFrgsGmz any chance you would weigh in here? In the past you have submitted similar PRs and would like your insight into these changes.

[LeStarch]

Functionally, the code submitted here should operate identically to the original!

I don't know the relative performance of the list comprehension vs the list() function call.

[thomas-bc]

LGTM!
For the list() vs comprehension matter, list() seems to be more optimal indeed (see here). However we're only iterating over a couple of args at most so performance should not be a decision factor here in my opinion.
That being said, I agree with the change!

[ThibFrgsGmz]

Can only do it tonight (in 10h - NZ time) as it's not convenient on Github Mobile App.

[LeStarch]

@ThibFrgsGmz if you are willing to take a look, then I am willing to wait until you have it done as you provide good insight.

[ThibFrgsGmz]

LGTM!

Review conducted as scheduled 10 hours later ahah :D

[LeStarch]

@ThibFrgsGmz @thomas-bc thanks for the analysis! I will merge this given your approvals.

@v1k1nghawk thanks for the submission!