-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor containers iteration for performance #127
Refactor containers iteration for performance #127
Conversation
@ThibFrgsGmz any chance you would weigh in here? In the past you have submitted similar PRs and would like your insight into these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally, the code submitted here should operate identically to the original!
I don't know the relative performance of the list comprehension vs the list()
function call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
For the list()
vs comprehension matter, list()
seems to be more optimal indeed (see here). However we're only iterating over a couple of args
at most so performance should not be a decision factor here in my opinion.
That being said, I agree with the change!
Can only do it tonight (in 10h - NZ time) as it's not convenient on Github Mobile App. |
@ThibFrgsGmz if you are willing to take a look, then I am willing to wait until you have it done as you provide good insight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Review conducted as scheduled 10 hours later ahah :D
@ThibFrgsGmz @thomas-bc thanks for the analysis! I will merge this given your approvals. @v1k1nghawk thanks for the submission! |
Change Description
Rationale
Future Work
None