Adding safer JSON parsing for NaN Infinity and null #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwest115
reviewed
Jul 14, 2023
Comment on lines
+70
to
+76
| this.FLAG = "-_-您好"; // Extended character usage make collisions less-likely | ||
| this.MAPPINGS = [ | ||
| ["-Infinity", this.FLAG + "-inf", -Infinity], | ||
| ["Infinity", this.FLAG + "inf", Infinity], | ||
| ["NaN", this.FLAG + "nan", NaN], | ||
| ["null", this.FLAG + "null", null] | ||
| ]; |
There was a problem hiding this comment.
@LeStarch why are we using a flag here? Is it so that if "-inf", "inf", "nan", or "null" appear in a string we could differentiate between that and the substring converted by the SafeParser?
There was a problem hiding this comment.
Yes. A better flag-free solution would have required changes on both the Python end and here. It seemed a localized solution converting to something safe and immediately back was a better solution because:
- Colocated changes
- Does not increase size of transmitted data
- These cases should be sufficiently rare as to not merit a much more complex and comprehensive solution
There was a problem hiding this comment.
thanks for the explanation! looks good to me!
jwest115
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes a bug where Python's JSON supports NaN and Infinity values, but JavaScript does not. This fix replaces those references with a string representation and then replaces them back in post.