Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate/fpp v2 #2293

Merged
merged 112 commits into from
Oct 5, 2023
Merged

Integrate/fpp v2 #2293

merged 112 commits into from
Oct 5, 2023

Conversation

LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Oct 3, 2023

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Integrate new FPP

@LeStarch LeStarch requested a review from bocchino October 3, 2023 01:24
@bocchino bocchino mentioned this pull request Oct 3, 2023
Closed
2 tasks
bocchino
bocchino approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I scanned through it. Most of the changes are updates to symbol names to conform to the new conventions.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 5, 2023
View reviewed changes
Svc/ComLogger/test/ut/ComLoggerTester.hpp
public ComLoggerGTestBase
{

public:
Tester(const char *const compName);
ComLoggerTester(const char *const compName);

Check warning

Code scanning / CppCheck

Single-parameter constructors should be marked explicit. Warning test

Single-parameter constructors should be marked explicit.
Svc/Deframer/test/ut-fprime-protocol/DeframerTester.hpp
//! Construct a Tester
Tester(InputMode::t inputMode);
//! Construct a DeframerTester
DeframerTester(InputMode::t inputMode);

Check warning

Code scanning / CppCheck

Single-parameter constructors should be marked explicit. Warning test

Single-parameter constructors should be marked explicit.
Svc/Deframer/test/ut/DeframerTester.hpp
@@ -37,7 +37,7 @@
// ----------------------------------------------------------------------
class MockDeframer : public DeframingProtocol {
public:
MockDeframer(Tester& parent);
MockDeframer(DeframerTester& parent);

Check warning

Code scanning / CppCheck

Single-parameter constructors should be marked explicit. Warning test

Single-parameter constructors should be marked explicit.
Svc/Deframer/test/ut/DeframerTester.hpp
//!
Tester(ConnectStatus::t bufferOutStatus = ConnectStatus::CONNECTED);
DeframerTester(ConnectStatus::t bufferOutStatus = ConnectStatus::CONNECTED);

Check warning

Code scanning / CppCheck

Constructors callable with one argument should be marked explicit. Warning test

Constructors callable with one argument should be marked explicit.
Svc/Framer/test/ut/FramerTester.hpp
@@ -29,13 +29,13 @@
//! Mock framing protocol
class MockFramer : public FramingProtocol {
public:
MockFramer(Tester& parent);
MockFramer(FramerTester& parent);

Check warning

Code scanning / CppCheck

Single-parameter constructors should be marked explicit. Warning test

Single-parameter constructors should be marked explicit.
Svc/LinuxTime/test/ut/LinuxTimeTester.hpp
@@ -20,9 +20,9 @@

public:

Tester(const char *const compName);
LinuxTimeTester(const char *const compName);

Check warning

Code scanning / CppCheck

Single-parameter constructors should be marked explicit. Warning test

Single-parameter constructors should be marked explicit.
This was referenced Oct 5, 2023
Merged
Merged
LeStarch and others added 23 commits October 5, 2023 13:49
@LeStarch
Migrating ActiveTextLogger unit tests to v3.4.0 standards
2894809
@LeStarch
Migrating LinuxTime unit tests to v3.4.0 standards
115ec75
@LeStarch
Migrating Deframer unit tests to v3.4.0 standards
324965b
@LeStarch
Migrating Deframer unit tests to v3.4.0 standards
27cbd35
@LeStarch
Migrating BufferRepeater unit tests to v3.4.0 standards
2beb250
@LeStarch
Migrating TlmChan unit tests to v3.4.0 standards
72855d4
@LeStarch
Migrating GenericHub unit tests to v3.4.0 standards
3eb4629
@LeStarch
Migrating BufferAccumulator unit tests to v3.4.0 standards
3a777dc
@LeStarch
Migrating LinuxTimer unit tests to v3.4.0 standards
5381b5d
@LeStarch
Migrating BufferManager unit tests to v3.4.0 standards
52b6819
@LeStarch
Migrating CmdSplitter unit tests to v3.4.0 standards
e0266de
@LeStarch
Migrating ComQueue unit tests to v3.4.0 standards
400c47e
@LeStarch
Migrating Os unit tests to v3.4.0 standards
f6c95de
@LeStarch
Federating FPP tools with release versions
a086638
@LeStarch
Python formatting
b9be8a7
@LeStarch
Reverting FPPTest to correctly working build
ce5f2df
@LeStarch
Removing minor dead code and comments
6d45e8e
thomas-bc
thomas-bc approved these changes Oct 5, 2023
View reviewed changes
cmake/autocoder/fpp.cmake Outdated Show resolved Hide resolved
@LeStarch LeStarch merged commit f797734 into nasa:devel Oct 5, 2023
36 checks passed
LeStarch added a commit to fprime-community/fprime-workshop-led-blinker that referenced this pull request Oct 5, 2023
@LeStarch
Merged version of nasa/fprime#2293
6d7b9c5
LeStarch added a commit to fprime-community/fprime-tutorial-math-component that referenced this pull request Oct 5, 2023
@LeStarch
Merged version of nasa/fprime#2293
135b379
thomas-bc added a commit to fprime-community/fprime-workshop-led-blinker that referenced this pull request Oct 5, 2023
@LeStarch @kevin-f-ortega @thomas-bc
Fixes for nasa/fprime#2293 (#43)
5e6dba0 
* Updating to v3.3.2

* Fixed else statement otherwise events and port invocations to gpio would happen on every schedIn while blinking is false

* Removing redundant instruction (#39)

* Clarify instructions (#40)

* nasa/fprime#2239

* Reorder #include instruction

* Clarify where to add parameterUpdated

* Fix ... usage

* Clarify gpio configuration

* Update full-integration.md

* Clarify testing

* Update project-setup.md

* Update component-implementation-1.md

* minor changes

* add newline

* Change parameterUpdated scope

* Migrating Led unit tests to v3.4.0 standards

* Syncing docs and code

* Merged version of nasa/fprime#2293

---------

Co-authored-by: Kevin F. Ortega <kevin.f.ortega@gmail.com>
Co-authored-by: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com>
thomas-bc pushed a commit to fprime-community/fprime-tutorial-math-component that referenced this pull request Oct 5, 2023
@LeStarch
nasa/fprime#2293 Fixes (#15)
d4f5c39 
* Migrating MathSender unit tests to v3.4.0 standards

* Migrating MathReceiver unit tests to v3.4.0 standards

* Fixing UT writing

* Merged version of nasa/fprime#2293
@Natee9969
Copy link

โครงการริเริ่ม/ผู้สร้าง
ส่วนประกอบที่ได้รับผลกระทบ
สถาปัตยกรรมที่ได้รับผลกระทบ
ประเด็นที่เกี่ยวข้อง)
มีการทดสอบหน่วย (มี/ไม่มี)
สร้างโดยไม่มีข้อผิดพลาด (y/n)
หน่วยทดสอบ ผ่าน (มี/ไม่มี)
รวมเอกสารประกอบ (มี/ไม่มี)

เปลี่ยนคำอธิบาย

บูรณาการ FPP ใหม่

LeStarch:integrate/fpp-v2

@Natee9969
Copy link

LeStarch:integrate/fpp-v2

@thomas-bc thomas-bc mentioned this pull request Oct 9, 2023
Merged
@LeStarch LeStarch added the Update Instructions Needed Need to add instructions in the release notes for updates. label Oct 12, 2023
@LeStarch
Copy link
Collaborator Author

This PR at minimum requires a rename of GTestBase.hpp.

@thomas-bc thomas-bc mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-bc thomas-bc thomas-bc approved these changes

@bocchino bocchino bocchino approved these changes

Assignees
No one assigned
Labels
Update Instructions Needed Need to add instructions in the release notes for updates.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeStarch @Natee9969 @bocchino @thomas-bc