Fix MacOS CI #2466
Merged
Fix MacOS CI #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-bc
commented
Jan 4, 2024
| @@ -17,7 +17,7 @@ export FPUTIL_TARGETS=("generate" "generate --ut" "build" "build --all" "check - | |||
| function fputil_action { | |||
| export WORKDIR="${1}" | |||
| export TARGET="${2}" | |||
| let JOBS="${JOBS:-$(( ( RANDOM % 9 ) + 1 ))}" | |||
| let JOBS="${JOBS:-$(( ( RANDOM % 100 ) + 1 ))}" | |||
There was a problem hiding this comment.
Consistent with what was prior to #2437
Also wasn't modified here: https://github.com/nasa/fprime/pull/2466/files#diff-f2defb2d2bbc3a725bff91bb51af54316c775cb3ccbf549f21a77d12411ee08bR46
LeStarch
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Should fix #2462
Limiting to 2 parallel jobs for macOS CI. Keeping the random(1, 100) for non-macOS runs.
2 was chosen very much arbitrarily as it seems to pass, while I've seen runs with 4 parallel jobs fail. Let me know if you have any input on that value.
Future Work
Be on the lookout for CI failures.