-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AcConstants.ini #2496
Remove AcConstants.ini #2496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I question if we can do this yet. We need the Ai.xml
for making dictionaries, and we need Ac.ini
in some form to make the Ai.xml
. Thus by deleting this, we theoretically could get corrupted dictionaries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete the commented out line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For those following along at home, the realization is that AcConstants.ini
is ignored in XML that was generated from FPP. Thus it is only needed for the 2.x
style of writing XML by hand. Since this has been de-scoped, we can merge this!
Change Description
Fix #1579 and #1893
Remove
AcConstants.ini
file as it has been replaced byAcConstants.fpp
. Updates relevant documentation entries.May break some of the autocoding capabilities of
codegen.py
(?), but we are only using the dictionary autocoder which doesn't need it.Rationale
File is not being used and may cause confusion for users
Testing/Review Recommendations
CI
Other
Associated fprime-tools PR: nasa/fprime-tools#192