Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GunnsDraw netexport should catch mixing fluid & basic links #13

Closed
jasonlharvey opened this issue Apr 14, 2021 · 0 comments
Closed

GunnsDraw netexport should catch mixing fluid & basic links #13

jasonlharvey opened this issue Apr 14, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone
Release v19.4

Comments

@jasonlharvey
Copy link
Contributor

It's too easy to insert some basic links in fluid networks, and vice-versa. GunnsBasicLink and GunnsFluidLink are easy to confuse with each other because they have the same looking shape.

Update netexport to error out if it detects fluid links in a basic network or vice-versa.
@jasonlharvey jasonlharvey added the enhancement New feature or request label Apr 26, 2021
jasonlharvey added a commit that referenced this issue Jan 27, 2022
@jasonlharvey
(#13) netexport checks for mix of basic and fluid links
cdd9710
@jasonlharvey jasonlharvey added this to the Release v19.4 milestone Jan 27, 2022
@jasonlharvey jasonlharvey mentioned this issue Jan 19, 2024
Closed
SamEvani pushed a commit to Axiom-Space/gunns that referenced this issue Jul 31, 2024
@SimminSteveO
Pull request nasa#13: Added getter for mMaxCapacity
6df69e9 
Merge in IPA/gunns from feature/ENG-92288-add-mMaxCapacity-getter to ax-gunns

* commit '480aece1353aa7db677bd6ea2dbf5875c1f989cd':
  Added getter for mMaxCapacity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release v19.4
Development

No branches or pull requests
1 participant
@jasonlharvey