Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pump/fan tuning helper spreadsheet max reference curve flow rate #41

Closed
1 task done
jasonlharvey opened this issue Apr 8, 2022 · 0 comments
Closed
1 task done

Pump/fan tuning helper spreadsheet max reference curve flow rate #41

jasonlharvey opened this issue Apr 8, 2022 · 0 comments
Labels
bug Something isn't working
Milestone
Release v19.4

Comments

@jasonlharvey
Copy link
Contributor

jasonlharvey commented Apr 8, 2022 •
edited
Loading

In columns DA-DB in aspects/fluid/tuning/Gunns_Pump_Fan_Tuning_Helper.xlsx, we attempt to estimate the maximum flow rate of the reference performance curve. The method doesn't work in all cases because it's not a proper root-finding method, like we use in runtime.

  • do it properly.
@jasonlharvey jasonlharvey added the bug Something isn't working label Apr 8, 2022
jasonlharvey added a commit that referenced this issue Apr 8, 2022
@jasonlharvey
(#41) improved root finding method and notify user of bad curve
6f31894
@jasonlharvey jasonlharvey added this to the Release v19.4 milestone Aug 10, 2022
SamEvani pushed a commit to Axiom-Space/gunns that referenced this issue Jul 31, 2024
@SamEvani
Pull request nasa#41: Hotfix/lossless source transportflux fix
64638b2 
Merge in IPA/gunns from hotfix/lossless_source_transportflux_fix to ax-gunns

* commit 'e9d086c4b20ae6e77de8903170dcf0142cb41189':
  Removing print statements
  Had to copy over some other virtual funcitons to make it call the right one?
  Wrote custom transportFlux() function; Turns out I also need to rewrite computeFlows() or GunnsBasicSource::computeFlows() will still call GunsnBasicLink::transportFlux() bc it's declared virtual
  Expanded the test and realized the 0V output case was important too
  I believe I fixed the test
  Initial test commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release v19.4
Development

No branches or pull requests
1 participant
@jasonlharvey