Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRICK ICG workaround for GunnsFluidDistributedIf.hh #43

Closed
2 tasks done
jasonlharvey opened this issue Apr 20, 2022 · 1 comment
Closed
2 tasks done

TRICK ICG workaround for GunnsFluidDistributedIf.hh #43

jasonlharvey opened this issue Apr 20, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jasonlharvey
Copy link
Contributor

jasonlharvey commented Apr 20, 2022

There is a problem with Trick ICG in RHEL8 that breaks Trick View's and TrickHLA's interface with some attributes of the GunnsFluidDistributedIfData class. Trick has the wrong address offsets for the variables. Trick team thinks it may be an incompatibility between ICG and the llvm version on RHEL8.

This was the Trick issue: nasa/trick#1308, and has since been fixed in Trick release 19.4. See comments below about the range of Trick commits that had the problem.

As a workaround, we can make Trick fall back to its 'compat15' function to correctly determine the class variable offsets, by including these lines in GunnsFluidDistributedIf.hh:

#ifdef TRICK_ICG
#endif

The ICG problem may affect other code as well.

  • make this update to clear up the problem with GunnsFluidDistributedIfData for now.
  • leave this issue open to work any other similar problems that come up, and to implement Trick's proper fix to ICG when it's available.
@jasonlharvey jasonlharvey added the enhancement New feature or request label Apr 20, 2022
@jasonlharvey jasonlharvey self-assigned this Apr 20, 2022
jasonlharvey added a commit that referenced this issue Apr 20, 2022
@jasonlharvey
Copy link
Contributor Author

The Trick bug has been found and fixed in Trick release 19.4. The cause was identified to be from a commit on 9/14/2021 and affects all systems that use LLVM versions 10+. So those systems should avoid using Trick versions between 9/14/2021 and the 19.4 release.

jasonlharvey added a commit that referenced this issue Aug 5, 2022
@jasonlharvey jasonlharvey added this to the Release v19.4 milestone Aug 10, 2022
SamEvani pushed a commit to Axiom-Space/gunns that referenced this issue Jul 31, 2024
Merge in IPA/gunns from feature/AXST-188083-update-thermal-model to ax-gunns

* commit 'a45469f91b8ce5688db2687a39cd7a8ccc5cfabb':
  Changed to reflect new .sm architecture
  Changed ICD naming
  Changed file structure
  Changed again
  Updated names
  Added new networks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant