Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocation misnamed in GunnsElectBattery.cpp #75

Closed
jasonlharvey opened this issue May 9, 2023 · 0 comments
Closed

Allocation misnamed in GunnsElectBattery.cpp #75

jasonlharvey opened this issue May 9, 2023 · 0 comments
Assignees
@jasonlharvey
Labels
bug Something isn't working
Milestone
Release v19.5

Comments

@jasonlharvey
Copy link
Contributor

gunns/aspects/electrical/Batt/GunnsElectBattery.cpp

Line 179 in 7dc6e1b

TS_NEW_CLASS_ARRAY_EXT(mCells, static_cast<int>(mNumCells), GunnsElectBatteryCell, (), std::string(mName) + ".mCell");

Should be ".mCells", not ".mCell" (missing the ending s) so that the allocation name matches the variable that points to that memory.
@jasonlharvey jasonlharvey added the bug Something isn't working label May 9, 2023
@jasonlharvey jasonlharvey self-assigned this May 9, 2023
jasonlharvey added a commit that referenced this issue May 12, 2023
@jasonlharvey
(#75) battery allocation name (#77) fluid distributed refactor
8f7099e
@jasonlharvey jasonlharvey added this to the Release v19.5 milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonlharvey jasonlharvey

Labels
bug Something isn't working
Projects
None yet
Milestone
Release v19.5
Development

No branches or pull requests
1 participant
@jasonlharvey