Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable net cap DV threshold in GunnsElectDistributedIf #92

Closed
3 tasks done
jasonlharvey opened this issue Aug 24, 2023 · 0 comments · Fixed by #95
Closed
3 tasks done

Configurable net cap DV threshold in GunnsElectDistributedIf #92

jasonlharvey opened this issue Aug 24, 2023 · 0 comments · Fixed by #95
Assignees
@jasonlharvey
Labels
enhancement New feature or request
Milestone
Release v19.5

Comments

@jasonlharvey
Copy link
Contributor

jasonlharvey commented Aug 24, 2023 •
edited
Loading

GunnsElectDistributedIf needs to have a configurable threshold for the network capacitance delta-voltage check in updateSupplyData(), instead of the hardcoded DBL_EPSILON. This allows users to tweak how much conductance needs to be in between the voltage supplies and the interface for them to be considered available.

  • add threshold to the link configuration data, use it in the link.
  • update the GunnsDraw shape master
  • update the link help page
@jasonlharvey jasonlharvey added the enhancement New feature or request label Aug 24, 2023
@jasonlharvey jasonlharvey self-assigned this Aug 24, 2023
jasonlharvey added a commit that referenced this issue Aug 30, 2023
@jasonlharvey
(#92) add config data to distributed power interface link
e2b8f7f
@jasonlharvey jasonlharvey linked a pull request Aug 30, 2023 that will close this issue
(#92) add config data to distributed power interface link #95
Merged
jasonlharvey added a commit that referenced this issue Aug 30, 2023
@jasonlharvey
Merge pull request #95 from nasa/92-configurable-net-cap-dv-threshold…
7037249 
…-in-gunnselectdistributedif

(#92) add config data to distributed power interface link
@jasonlharvey jasonlharvey reopened this Aug 30, 2023
@jasonlharvey jasonlharvey added this to the Release v19.5 milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonlharvey jasonlharvey

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release v19.5
Development

Successfully merging a pull request may close this issue.

(#92) add config data to distributed power interface link nasa/gunns
1 participant
@jasonlharvey