-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HARMONY-388: Better consistency across Python repos #5
Conversation
…uidance on environment setup
.gitignore
Outdated
@@ -113,6 +113,7 @@ venv/ | |||
ENV/ | |||
env.bak/ | |||
venv.bak/ | |||
harmony-ntz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious - what is this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme recommended creating a virtual environment called harmony-ntz with pyenv-virtualenv. If you use venv to do the same, it creates a directory with that name for the virtual environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing people have not been using the virtual environment naming suggested in the readme in favor of something like "venv". (I used harmony-ntz when I created my virtual environment because that seemed to be what was being suggested.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using pyenv virtualenv
, but for consistency with ourselves and other projects I've seen and easier setup of $PATH
, it may be better to just have the environment called env
(or venv
or you pick one) in every project, so we can run the same source env/bin/activate
everywhere and have the same gitignore everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. If you're editing the README again, you may want to mention up front that you can also just docker pull harmonyservices/netcdf-to-zarr
.gitignore
Outdated
@@ -113,6 +113,7 @@ venv/ | |||
ENV/ | |||
env.bak/ | |||
venv.bak/ | |||
harmony-ntz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using pyenv virtualenv
, but for consistency with ourselves and other projects I've seen and easier setup of $PATH
, it may be better to just have the environment called env
(or venv
or you pick one) in every project, so we can run the same source env/bin/activate
everywhere and have the same gitignore everywhere.
What follows are the acceptance criteria and what I found or did to address them. (I also spoke with Chris prior to submitting this PR.)