Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate regression tests' default environment. #62

Merged
merged 3 commits into from
May 25, 2023

Conversation

flamingbear
Copy link
Member


Description

Added new convention to separate the conda environent names. Previously all images used an environment named papermill This PR updates all to append the image name to this to allow testing of more than one regression test at a time locally. All environment.yaml files have had their names appended with the appropriate image name.

Jira Issue ID

DAS-1606

Local Test Steps

Build the images and run the tests locally against any environment.

PR Acceptance Checklist

  • [n/a] Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

Copy link
Member

@owenlittlejohns owenlittlejohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this change; it's a small thing, but I like the lack of ambiguity now in the environment names and the ability to have all the environments locally. Thanks also for humouring me and putting this in a separate PR for clarity.

@flamingbear flamingbear merged commit db5e2fe into main May 25, 2023
@flamingbear flamingbear deleted the mhs/DAS-1606/update-conda-environment-names branch May 25, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants