adding granite test bench + fixes #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ange survey static because of jem plan; hard to change command_astrobee config name
bcoltin
approved these changes
Feb 12, 2024
| @@ -134,59 +136,87 @@ def __init__(self, robot_name): | |||
| self.sock_input.bind(self.input_path) | |||
| self.sock_input.listen(1) # Listen for one connection | |||
| self.sock_input_connected = False | |||
| self.sock_input_conn = None | |||
There was a problem hiding this comment.
Might want to add some more comments explaining what's going on with these sockets
There was a problem hiding this comment.
added some comments :)
Improve logging in command_astrobee.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.