Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to bag_migrate branch of isaac_msgs #48

Closed
wants to merge 3 commits into from

Conversation

trey0
Copy link
Contributor

@trey0 trey0 commented May 19, 2022

This PR should be held until the following ones are merged:

I'm frankly not sure when the ISAAC bag migration CI test will start to pass on GitHub. (Like it might need the astrobee PR to be merged into master first?)

@trey0 trey0 changed the base branch from develop to master June 3, 2022 18:52
@trey0 trey0 changed the base branch from master to develop June 3, 2022 18:52
@trey0
Copy link
Contributor Author

trey0 commented Jun 3, 2022

I noticed the diff information was stale and changed the base branch to 'master' then back to 'develop' to try and get the diff to be update, as a workaround for isaacs/github#750 . Didn't seem to work.

@trey0
Copy link
Contributor Author

trey0 commented Jun 14, 2022

Looks like a new PR is needed for this now that the other PRs have been merged.

@trey0 trey0 closed this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant