MMT-3392: Update MMT to use the new react crud forms for services #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmistry1
commented
Sep 6, 2023
app/views/drafts/new.html.erb
Outdated
| @@ -3,14 +3,17 @@ | |||
| <% end %> | |||
|
|
|||
| <div class="grid-row row-content"> | |||
| <% if (resource_name == 'tool_draft' or resource_name == 'variable_draft') and Rails.configuration.react_forms_enabled %> | |||
| <% if (resource_name == 'tool_draft' or resource_name == 'variable_draft' or resource_name == 'service_draft') and Rails.configuration.react_forms_enabled %> | |||
There was a problem hiding this comment.
remove resource_name check
dmistry1
commented
Sep 6, 2023
app/views/drafts/edit.html.erb
Outdated
| @@ -7,7 +7,7 @@ | |||
| <% elsif @unconfirmed_version %> | |||
| <%= render partial: 'drafts/shared/unconfirmed_version' %> | |||
| <% else %> | |||
| <% if (resource_name == 'tool_draft' or resource_name == 'variable_draft') and Rails.configuration.react_forms_enabled %> | |||
| <% if (resource_name == 'tool_draft' or resource_name == 'variable_draft' or resource_name == 'service_draft') and Rails.configuration.react_forms_enabled %> | |||
There was a problem hiding this comment.
remove resource_name
dmistry1
commented
Sep 6, 2023
| @@ -93,7 +93,7 @@ class NavigationView extends React.Component<NavigationViewProps, NavigationView | |||
| editor.saveDraft(draft).then((draft) => { | |||
| editor.draft = draft | |||
| this.setState({ saving: false }) | |||
| if (editor.documentType === 'variable_drafts') { | |||
| if (editor.documentType === 'variable_drafts' || editor.documentType === 'service_draft') { | |||
There was a problem hiding this comment.
Add a comment to remove serviceDraft check
tle1989
approved these changes
Sep 6, 2023
mandyparson
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.