MMT-1151 display banner if open draft exists for variable #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| it 'displays the draft' do | ||
| within '.eui-breadcrumbs' do | ||
| expect(page).to have_content('Drafts') |
There was a problem hiding this comment.
not totally necessary, but you could make this more specific and check for 'Variable Drafts'
|
|
||
| it 'displays the draft' do | ||
| within '.eui-breadcrumbs' do | ||
| expect(page).to have_content('Drafts') |
There was a problem hiding this comment.
same comment as above
charleshuang80
requested changes
Sep 28, 2017
| <%= link_to 'Yes', collection_draft_path(options[:draft_id]), class: 'eui-btn--blue spinner is-invisible', id: 'not-current-provider-view-draft-link' %> | ||
| <%= link_to 'Yes', edit_collection_draft_path(options[:draft_id], form: options[:draft_form]), class: 'eui-btn--blue spinner is-invisible', id: 'not-current-provider-edit-draft-link' %> | ||
| <% if options[:variable] %> | ||
| <%= link_to 'Yes', variable_draft_path(options[:draft_id]), class: 'eui-btn--blue spinner is-invisible', id: 'not-current-provider-view-draft-link' %> |
There was a problem hiding this comment.
The ids for the links to view and edit the variable drafts are identical to the ids for links for the collection drafts here. They should be unique, right?
There was a problem hiding this comment.
Only one set of IDs is rendered onto the page, so they are unique in the browser
charleshuang80
approved these changes
Sep 28, 2017
abbottry
approved these changes
Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.