Mmt-3116: Update MMT to use the new "Order Option" API #955
Conversation
htranho
requested review from
macrouch,
jceaser,
cgokey,
eudoroolivares2016,
william-valencia,
tle1989,
dmistry1 and
hgrams-e84
| @@ -54,30 +131,95 @@ def create | |||
| end | |||
| end | |||
|
|
|||
| def show | |||
| def deprecate_order_option | |||
There was a problem hiding this comment.
I think a comment may be needed something along the lines of "deprecate AKA remove order option" or something to that affect. To the uninitiated it looks like you renamed a function you want to delete latter. Everyone involved probably understands you, but I'm sure someone in the future will be confused.
There was a problem hiding this comment.
No, this function is to do deprecating an order option (not it self is deprecated)
| end | ||
|
|
||
| def delete_order_option | ||
| response = cmr_client.remove_order_option(native_id: params[:id], provider_id: current_user.provider_id, token: token) |
There was a problem hiding this comment.
I am slightly concerned about us deleting the order-options. When we migrated the order-options from legacy services we associated them to collections and services by adding them as part of the data payload, if we delete the order-option from CMR it will still remain on the payload associated between the service and collection. Querying for an order-option with the concept-id in that payload will of course return no results.
There was a problem hiding this comment.
I don't think that is necessarily part of this ticket's scope though
No description provided.