Mmt 3203 - Update MMT to use the latest react components (support for umm-var) #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tle1989
reviewed
Apr 4, 2023
| @@ -63,8 +63,8 @@ def create | |||
|
|
|||
| if get_resource.save | |||
| # Successful flash message | |||
| flash[:success] = I18n.t("controllers.draft.#{plural_resource_name}.create.flash.success") | |||
| Rails.logger.info("Audit Log: #{current_user.urs_uid} successfully created #{resource_name.titleize} with title: '#{get_resource.entry_title}' and id: #{get_resource.id} for provider: #{current_user.provider_id}") | |||
| flash[:success] = I18n.t("controllers.draft.#{plural_resource_name}.create.flash.success") | |||
There was a problem hiding this comment.
remove extra space here line 66, 67
tle1989
reviewed
Apr 4, 2023
| redirect_to manage_variables_path, flash: { error: "No matches were found for #{@associated_collection_id}" } | ||
| elsif !current_provider?(current_collection_response.body.dig('items', 0, 'meta', 'provider-id')) | ||
| redirect_to manage_variables_path, flash: { error: "Variables can only be associated to collections within the same provider. To create a variable for #{@associated_collection_id} you must change your provider context." } | ||
| super and return if params[:associated_collection_id].blank? |
There was a problem hiding this comment.
remove extra space from line 23-35
tle1989
approved these changes
Apr 4, 2023
added 3 commits
April 4, 2023 10:39
…o form rendering of react component.
htranho
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.