ogma-core: Map float and double to the same types in C++. Refs #138.
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ROS backend is, by default, assuming that the data carried by std_msgs::msg::Float32 is of type float32, when it appears to be just a float. The same is happening for Float64, float64 and double. The code currently produced for those cases does not compile. The type mappings are described in http://docs.ros.org/en/humble/Concepts/Basic/About-Interfaces.html, which states that, in C++, float and double should be used. This commit modifies the ROS backend so that it expects global variables of input types `float` and `double` in the variable DB to have the types `float` and `double`, respectively, in the generated C++ code.
…#138. This commit modifies an example to use also an input variable of type float and one of type double, both of which were failing in the ROS backend. The example in question is currently being used by a CI script to test the ROS backend, making the new example serve as a regression test.
ivanperez-keera
force-pushed
the
develop-ros-float
branch
from
ff4a060
to
b20fdaf
Compare
ivanperez-keera
changed the title
ogma-core: Map float and double to the same types in C++. Refs #138.ogma-core: Map float and double to the same types in C++. Refs #138.
|
Change Manager: Verified that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the ROS backend to map the input types
floatanddoubleto the same types in the generated C++ ROS nodes, as prescribed in the solution proposed for #138.