Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer able to reorder stacked plots #6158

Closed
2 of 7 tasks
akhenry opened this issue Jan 23, 2023 · 7 comments · Fixed by #6199 or #6346
Closed
2 of 7 tasks

No longer able to reorder stacked plots #6158

akhenry opened this issue Jan 23, 2023 · 7 comments · Fixed by #6199 or #6346
Labels
bug:regression It used to work. Now it doesn't :( needs:e2e Needs an e2e test severity:critical type:bug
Milestone
Target:2.2.0

Comments

@akhenry
Copy link
Contributor

akhenry commented Jan 23, 2023 •
edited

Summary

Historically it has been possible to reorder the sub-plots within a stacked plot by changing the order of the elements in the element pool. The reorder function was added to the composition API to facilitate this.

Expected vs Current Behavior

The order of plots within a stacked plot should be the same as the order of composition in the elements pool

Steps to Reproduce

  1. Create a stacked plot with three plots in it
  2. Edit the plot
  3. In the elements pool, drag the objects around to reorder them
  4. Observe that the order of the plots within the stacked plot does not change.

Environment

  • Open MCT Version: 2.1.6-SNAPSHOT
  • Deployment Type: VIPER Test

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@akhenry akhenry added type:bug severity:critical bug:regression It used to work. Now it doesn't :( labels Jan 23, 2023
@akhenry akhenry added this to the Target:2.1.6 milestone Jan 23, 2023
@ozyx
Copy link
Member

ozyx commented Jan 24, 2023

Reordering does happen when navigating away and navigating back but should happen immediately

@scottbell
Copy link
Contributor

Was able to replicate the issue, and @ozyx's workaround:

Screen.Recording.2023-01-25.at.11.19.21.AM.mov

Now looking into what's going on.

@shefalijoshi shefalijoshi mentioned this issue Jan 26, 2023
Merged
15 tasks
@scottbell scottbell linked a pull request Jan 27, 2023 that will close this issue
Fix stacked plots legend #6199
Merged
15 tasks
@ozyx ozyx mentioned this issue Feb 1, 2023
Merged
15 tasks
@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Feb 2, 2023
@rukmini-bose
Copy link
Contributor

rukmini-bose commented Feb 6, 2023 •
edited

Testathon 2/6/23 The reorder now only happens upon saving the Stacked Plot. We don't have to navigate, but does not update in real-time in edit mode.

@ozyx
Copy link
Member

ozyx commented Feb 6, 2023

Testathon 2-6-2023:

Seeing the same thing as @rukmini-bose above. Reorder happens but only after save

@unlikelyzero unlikelyzero reopened this Feb 6, 2023
@ozyx ozyx self-assigned this Feb 15, 2023
@ozyx ozyx mentioned this issue Feb 15, 2023
Merged
15 tasks
@ozyx
Copy link
Member

ozyx commented Feb 15, 2023

Testing Instructions

  • Create a stacked plot and add some telemetry to it
  • In edit mode, reorder the items in the elements pool
  • Verify that the stacked plot items reorder correctly in real time, before save
  • Verify that Legend items are still accurate
  • Once done, hit save
  • Verify that the plot order persists and is still correct

ozyx added a commit that referenced this issue Feb 27, 2023
@ozyx
fix(#6158): StackedPlotItem reorders are reflected on the plot in rea…
fa6cbb6 
…l time (#6346)

* fix: ensure Vue can react to stacked plot item reorders

- Use Vue.$set instead of assignment so Vue can pick up StackedPlot composition reorders immediately

* test(e2e): add test for stacked plot item reorder

* docs: specify plot item order in comments

* fix: correct page.goto() url
vhenckel pushed a commit to vhenckel/openmct that referenced this issue Feb 28, 2023
@ozyx @vhenckel
fix(nasa#6158): StackedPlotItem reorders are reflected on the plot in…
fb052c0 
… real time (nasa#6346)

* fix: ensure Vue can react to stacked plot item reorders

- Use Vue.$set instead of assignment so Vue can pick up StackedPlot composition reorders immediately

* test(e2e): add test for stacked plot item reorder

* docs: specify plot item order in comments

* fix: correct page.goto() url
@rukmini-bose
Copy link
Contributor

verified testathon 3/9/23

@akhenry
Copy link
Contributor Author

akhenry commented Mar 14, 2023

Verified fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( needs:e2e Needs an e2e test severity:critical type:bug
Projects
None yet
Milestone
Target:2.2.0
6 participants
@akhenry @shefalijoshi @ozyx @scottbell @unlikelyzero @rukmini-bose