Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(#6199): Fix stacked plots legend #6247

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Feb 1, 2023

Issue #6176 #6158 #6209 #6231 #6159 #6176

  • Add listeners to remove stacked plot series and make keys unique

  • don't add overlay plots to stacked plot legends

  • Ensure series colors are drawn correctly in the plot legend

  • Remove legend from mct plot. Remove series reactivity from stackd plot and add them to the legend instead.

  • Clean up stacked plots so that the plot legend needs fewer props Also make sure that plot selection inside a stacked plot works - this had regressed due to plot annotations

  • Fix console error in plot elements pool and plot legend - reset arrays to empty

  • Ensure color in the y axis swatch updates correctly

  • Fix small issues with removing objects from STacked plots

  • Fix selection for annotations and also select stacked plot child items

  • fix notebook tagging

  • remove unused annotation editor and change selection to single object

  • remove reference to deleted css

  • fix e2e tests

  • Fix small typos into the selection context for Notebooks.

  • Add a typ that identifies that an annotation selection is coming from a search result


Co-authored-by: Scott Bell scott@traclabs.com

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

* Add listeners to remove stacked plot series and make keys unique

* don't add overlay plots to stacked plot legends

* Ensure series colors are drawn correctly in the plot legend

* Remove legend from mct plot. Remove series reactivity from stackd plot and add them to the legend instead.

* Clean up stacked plots so that the plot legend needs fewer props
Also make sure that plot selection inside a stacked plot works - this had regressed due to plot annotations

* Fix console error in plot elements pool and plot legend - reset arrays to empty
* Ensure color in the y axis swatch updates correctly

* Fix small issues with removing objects from STacked plots

* Fix selection for annotations and also select stacked plot child items

* fix notebook tagging

* remove unused annotation editor and change selection to single object

* remove reference to deleted css

* fix e2e tests

* Fix small typos into the selection context for Notebooks.

* Add a typ that identifies that an annotation selection is coming from a search result

---------

Co-authored-by: Scott Bell <scott@traclabs.com>
@scottbell scottbell enabled auto-merge (squash) February 1, 2023 18:21
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/2.1.6@dda6800). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             release/2.1.6    #6247   +/-   ##
================================================
  Coverage                 ?   55.15%           
================================================
  Files                    ?      607           
  Lines                    ?    26004           
  Branches                 ?     2343           
================================================
  Hits                     ?    14343           
  Misses                   ?    11009           
  Partials                 ?      652           
Flag Coverage Δ *Carryforward flag
e2e-ci 39.49% <0.00%> (?) Carriedforward from 8847c86
e2e-full 51.23% <0.00%> (?) Carriedforward from 8847c86
e2e-stable 53.91% <0.00%> (?)
unit 49.71% <0.00%> (?) Carriedforward from 8847c86

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dda6800...f0db18d. Read the comment docs.

@ozyx ozyx changed the title cherry-pick(#6199): Fix stacked plots legend (#6199) cherry-pick(#6199): Fix stacked plots legend Feb 1, 2023
@ozyx ozyx disabled auto-merge February 1, 2023 18:26
@ozyx ozyx enabled auto-merge (squash) February 1, 2023 18:28
@ozyx ozyx merged commit 060ee35 into release/2.1.6 Feb 1, 2023
@ozyx ozyx deleted the cherry-pick-6199 branch February 1, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants