-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stacked plots legend #6199
Fix stacked plots legend #6199
Conversation
…stacked-plot-will-not-remove-them-from-the-legend
…stacked-plot-will-not-remove-them-from-the-legend
…stacked-plot-will-not-remove-them-from-the-legend
… series moves from one y axis to another Optimize initialization of Plot configuration Ensure the the y axis form correctly saves any changes to the configuration Fix excluded limits test
…m/nasa/openmct into 5834-stacked-plot-removing-objects-from-a-stacked-plot-will-not-remove-them-from-the-legend
…t and add them to the legend instead.
Also make sure that plot selection inside a stacked plot works - this had regressed due to plot annotations
…s to empty Ensure color in the y axis swatch updates correctly
Codecov Report
@@ Coverage Diff @@
## master #6199 +/- ##
==========================================
+ Coverage 54.86% 55.36% +0.50%
==========================================
Files 607 607
Lines 25951 26036 +85
Branches 2350 2370 +20
==========================================
+ Hits 14238 14416 +178
+ Misses 11045 10960 -85
+ Partials 668 660 -8
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
…enmct into fix-stacked-plots-legend
…cked-plots-legend
…that identifies that an annotation selection is coming from a search result. Try to simplify handling of selection in Mct Plots
Annotation testing instructions: |
* Add listeners to remove stacked plot series and make keys unique * don't add overlay plots to stacked plot legends * Ensure series colors are drawn correctly in the plot legend * Remove legend from mct plot. Remove series reactivity from stackd plot and add them to the legend instead. * Clean up stacked plots so that the plot legend needs fewer props Also make sure that plot selection inside a stacked plot works - this had regressed due to plot annotations * Fix console error in plot elements pool and plot legend - reset arrays to empty * Ensure color in the y axis swatch updates correctly * Fix small issues with removing objects from STacked plots * Fix selection for annotations and also select stacked plot child items * fix notebook tagging * remove unused annotation editor and change selection to single object * remove reference to deleted css * fix e2e tests * Fix small typos into the selection context for Notebooks. * Add a typ that identifies that an annotation selection is coming from a search result --------- Co-authored-by: Scott Bell <scott@traclabs.com>
* Add listeners to remove stacked plot series and make keys unique * don't add overlay plots to stacked plot legends * Ensure series colors are drawn correctly in the plot legend * Remove legend from mct plot. Remove series reactivity from stackd plot and add them to the legend instead. * Clean up stacked plots so that the plot legend needs fewer props Also make sure that plot selection inside a stacked plot works - this had regressed due to plot annotations * Fix console error in plot elements pool and plot legend - reset arrays to empty * Ensure color in the y axis swatch updates correctly * Fix small issues with removing objects from STacked plots * Fix selection for annotations and also select stacked plot child items * fix notebook tagging * remove unused annotation editor and change selection to single object * remove reference to deleted css * fix e2e tests * Fix small typos into the selection context for Notebooks. * Add a typ that identifies that an annotation selection is coming from a search result --------- Co-authored-by: Scott Bell <scott@traclabs.com>
Closes #6176 #6158 #6209 #6231 #6159 #6176
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist