Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit lines revert on redraw after MDB override #7598

Closed
4 of 7 tasks
ozyx opened this issue Mar 15, 2024 · 1 comment
Closed
4 of 7 tasks

Limit lines revert on redraw after MDB override #7598

ozyx opened this issue Mar 15, 2024 · 1 comment
Labels
invalid duplicate or incorrectly filed severity:blocker type:bug

Comments

@ozyx
Copy link
Contributor

ozyx commented Mar 15, 2024

Summary

When applying an MDB override to change limit values on telemetry, those viewing an overlay plot containing that telemetry w/ limit lines enabled would see the lines correctly update to the new values. However, on zoom in/out, the limit lines will redraw the OLD limits before the override. This persists until refresh, and the values seen when hovering over the legend also revert to the old limits.

Untitled.mov

Above, I change the top limit from 10 to 11 and the bottom from -5 to -6. Then on zoom it reverts.

Expected vs Current Behavior

The limits should change and persist in the view immediately without reverting on rerender.

Steps to Reproduce

  1. Create an Overlay Plot
  2. Assign limits to a telemetry point that you plan to use to test this
  3. Drag that telemetry into the Overlay Plot
  4. Change the series config in the overlay plot settings to enable Limit Lines
  5. Observe the limit lines are displayed correctly
  6. Submit an MDB override to change the limits:
# Change the values themselves as you see fit
curl -X PATCH localhost:<port>/yamcs/api/mdb-overrides/path/to/parameter -d '{"action":"SET_DEFAULT_ALARMS","defaultAlarm":{"staticAlarmRange":[{"level":"WARNING","minInclusive":-0.03,"maxInclusive":0.03},{"level":"CRITICAL","minInclusive":-0.09,"maxInclusive":0.09}]}}'
  1. Observe the limits change immediately in the view
  2. Zoom in or out
  3. Observe the limits redraw the old limits before the override
  4. Hover over the legend, see that the old values are there for limits
  5. Nav away / back or refresh
  6. Correct limits are displayed

Environment

  • Open MCT Version: 4.0.0-next
  • Deployment Type: Testathon
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@ozyx ozyx added this to the Target:4.0.0 milestone Mar 15, 2024
@ozyx ozyx assigned ozyx and unassigned ozyx Mar 15, 2024
@ozyx
Copy link
Contributor Author

ozyx commented Mar 19, 2024

Moving this to openmct-yamcs as the fix is implemented there

@ozyx ozyx closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2024
@ozyx ozyx removed this from the Target:4.0.0 milestone Mar 19, 2024
@unlikelyzero unlikelyzero added the invalid duplicate or incorrectly filed label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid duplicate or incorrectly filed severity:blocker type:bug
Projects
None yet
Development

No branches or pull requests

2 participants