Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add os-impl-no-select.c for operating systems that do not have select (RTEMS 6 with network off) #1248

Closed
ghost opened this issue Apr 19, 2022 · 1 comment · Fixed by #1251 or #1250
Closed

Add os-impl-no-select.c for operating systems that do not have select (RTEMS 6 with network off) #1248

ghost opened this issue Apr 19, 2022 · 1 comment · Fixed by #1251 or #1250
Labels
draco-rc2 enhancement RTEMS
Milestone
Draco

Comments

@ghost
Copy link

ghost commented Apr 19, 2022

Is your feature request related to a problem? Please describe.
RTEMS 6.x removes the legacy network stack by default, and in doing so, removes the "select" call. Now, when the OSAL OSAL_CONFIG_INCLUDE_NETWORK option is set to FALSE, the OSAL/cFS build fails because it still expects a select call.

Describe the solution you'd like
I have implemented a src/os/portable/os-impl-no-select.c file along with the corresponding changes to the CMakeLists.txt file that uses os-impl-no-select.c when the INCLUDE_NETWORK option is FALSE, otherwise it uses os-impl-bsd-select.c as usual.

Requester Info
Alan Cudmore / NASA GSFC / Code 582.0
@ghost ghost self-assigned this Apr 19, 2022
@ghost ghost added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Apr 25, 2022
@astrogeco
Copy link
Contributor

CCB: 2022-04-27

@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Apr 27, 2022
astrogeco added a commit that referenced this issue May 2, 2022
@astrogeco
Merge pull request #1250 from acudmore/fix-1248-rtems-os-impl-no-select
07a134f 
Fix #1248, add os-impl-no-select.c for RTEMS
@astrogeco astrogeco mentioned this issue May 2, 2022
Merged
2 tasks
@astrogeco astrogeco mentioned this issue May 12, 2022
Merged
2 tasks
@ghost ghost mentioned this issue May 19, 2022
Closed
@skliper skliper added this to the Draco milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
draco-rc2 enhancement RTEMS
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

osal Integration candidate: Caelum-rc4+dev9 nasa/osal
FIX #1248, add os-impl-no-select.c for RTEMS
2 participants
@skliper @astrogeco