Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage tests for VxWorks at minimum to include reporting of all code that could be included in build #795

Closed
skliper opened this issue Feb 10, 2021 · 0 comments · Fixed by #826 or #835
Assignees
Labels
bug unit-test Tickets related to the OSAL unit testing (functional and/or coverage) vxworks
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Feb 10, 2021

Is your feature request related to a problem? Please describe.
Currently os-impl-bsd-socket.c can be included (and is by default) in the VxWorks build:

../portable/os-impl-bsd-sockets.c # Use BSD socket layer implementation

but it's not included in coverage testing or reported as part of status

So although code coverage reports 100%, we are NOT covering the possible FSW 100%... so it's a bit misleading.

Describe the solution you'd like
All possible code should be reported for coverage. Short term is just to add tests (track by hand) but eventually may benefit from a quick check that all the files included in the build are included in coverage analysis.

Describe alternatives you've considered
None

Additional context
Illuminated by investigation into #793, unreachable code wasn't being reported even though it was in the core build.

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 6.0.0 milestone Feb 10, 2021
skliper added a commit to skliper/osal that referenced this issue Feb 11, 2021
@skliper skliper added unit-test Tickets related to the OSAL unit testing (functional and/or coverage) and removed enhancement labels Feb 11, 2021
skliper added a commit to skliper/osal that referenced this issue Feb 17, 2021
skliper added a commit to skliper/osal that referenced this issue Feb 17, 2021
@skliper skliper self-assigned this Feb 18, 2021
skliper added a commit to skliper/osal that referenced this issue Feb 19, 2021
skliper added a commit to skliper/osal that referenced this issue Feb 19, 2021
skliper added a commit to skliper/osal that referenced this issue Feb 19, 2021
skliper added a commit to skliper/osal that referenced this issue Feb 25, 2021
@astrogeco astrogeco added the bug label Mar 1, 2021
astrogeco added a commit that referenced this issue Mar 1, 2021
Fix #795, Add uncovered vxworks source files to coverage statistics
astrogeco added a commit to nasa/cFS that referenced this issue Mar 1, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Fix nasa#795, Remove legacy time header format support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unit-test Tickets related to the OSAL unit testing (functional and/or coverage) vxworks
Projects
None yet
2 participants