Integration Candidate: 2020-05-27 #487
Conversation
Add the capability to store parameter names in addtion to pointers as part of the stub argument context data. Macroize the UT_Stub_RegisterContext function utstubs.h to also pass the parameter name in addition to the pointer. Also add hook-side accessor functions/macros to make it easier and more reliable to get this information from the context data.
These adaptor layers can be used on a variety of boards. Renaming the directory reflects that. Note - not renaming pc-rtems at this time, as that still has some non-generic aspects to it.
Fix #449, Rename BSPs to be generic
Fix #479, add name association to stub arguments
…nctional-test Fix #381, Add OS_TimerAdd functional test
…ional-Tests Fix #380, Add OS_TimeBase Api Functional Tests
|
@yammajamma and @jphickey got a unit test failure on nasa/cFS#96 |
|
This is a race condition in |
|
FYI -submitted #493. This is not a newly-added in the current IC - it exists in master branch, it was just not caught. |
weird, I guess it's an intermittent issue? The bundle build passed a couple of commits ago. |
Yes, its a race condition so it depends on the configuration/scheduler/load of the host system running the test. |
|
I saw this happening on the master branch on Friday intermittently, it was not doing this before then at at all. I tried to replicate it, but couldn't get it to do so, and tried to get others I know to run it and replicate it as well, and it didn't happen with them either, so I wasn't sure what the issue was. Figured I'd try and see if it happens again today, which I can see that it is. Are there changes that I can make to my file to alleviate the issue? |
Use a proper "setup" function to create the resources for the test. Add a delay loop to ensure that the child task has executed before continuing with the rest of the test.
|
See PR #495 which should fix this. |
Fix #493, race condition in idmap api test
now int to avoid possible string buffer overflow
Fix nasa#487, CFE_TIME_print format fix
Describe the contribution
Fix #380
Fix #381
Fix #449
Fix #479
Testing performed
https://github.com/nasa/cFS/pull/96/checks
Expected behavior changes
PR #467 - Rename BSPs that can be used on multiple platforms.
mcp750-vxworksbecomesgeneric-vxworkspc-linuxbecomesgeneric-linuxPR #480 - New features only, does not change existing behavior.
UT Hook functions now have the capability to get argument values by name, which is more future proof than assuming a numeric index.
PR #452 - Add functional test for
OS_TimerAddPR #481 - Added functional tests for
OS_TimeBase ApionOS_TimeBaseCreate,OS_TimeBaseSet,OS_TimeBaseDelete,OS_TimeBaseGetIdByName,OS_TimeBaseGetInfo,OS_TimeBaseGetFreeRunSystem(s) tested on
Ubuntu:Bionic
Additional context
Part of nasa/cFS#96
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.
Yasir Khan, NASA-GSFC