HOTFIX correct variables now used for euler-quaternion conversions #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem discovered in #115. No Jira Ticket available.
Summary of Changes
setEuler
withsetRPY
.setEuler
was resulting in quaternions that did not agree with the ones computed from Euler angles given to the action client script for the same action. For example, I could pass to the action client script the exact same set of Euler angles used for the first ArmMoveCartesian in TestArmMoveCartesianGuarded.plx, which are (3.14, 0, 0), but the orientation that resulted from the action client script would be different from the orientation that resulted from the plexil action call. (3.14, 0, 0) should result in the scoop's bottom facing down, and its opening facing away from the lander (+x-direction), but when called by plexil it would result in bottom up and facing toward lander, so it was as if the roll and yaw were being swapped.setRPY
instead.Test
Make sure you run the following on this branch, and every other repo on the master branch
Boot any world and run TestArmMoveCartesian.plx.
The ArmMoveCartesian should result in the scoop's bottom pointing directly up, and its opening pointing away from the lander. The subsequent ArmMoveCartesian_Q should result in the scoop's bottom pointing directly down, and its opening pointing away from the lander.
In the same world run TestArmMoveCartesianGuarded.plx.
The scoop's bottom should first point down at the ground, then be moved down into the ground and report that the force threshold was breached. It will then raise up high, then back down but will not quite reached the ground resulting in the force threshold not being breached.