Oceanwater 1010 implement telemetry arm faults status #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmdalal
reviewed
Nov 8, 2022
…of github.com:nasa/ow_autonomy into OCEANWATER-1010_implement_telemetry_arm_faults_status
…arm_faults_status
…arm_faults_status
|
@anthonykoutroulis Code looks good, build is clean, just awaiting a specific test (in ow_simulator) if any. |
|
This should have its own test, even if just for regression, since PLEXIL detects and reacts to arm faults, even if only through the system fault message. A sufficient test would be running any plan with lots of arm operations, injecting faults, and verifying behavior. Also, it needs to be rebased to an intermediate branch. |
…arm_faults_status
anthonykoutroulis
changed the base branch from
noetic-devel
to
OCEANWATER-934_telemetry_unification_epic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues:
Mostly artifact renaming and updating message definitions.
This issue has a corresponding and required branch on ow_simulator.
Summary of Changes
ArmFaultsto match Unified Telemetry spec ofArmFaultsStatusowl_msgswhich now houses ArmFaultsStatus (instead of ow_faults_detection)For more details, see the associated pull request on ow_simulator.
Test
Test with linked PR above.