Adding extract_subset_granule #86
Conversation
|
Hi @Omkar20895 can you please shift this new function into the granule_subset function rather than creating yet another function? The idea is to keep the core Podaacpy functions exactly as specified within the Podaac Webservices API Specification. The core fucntion names can be seen on the README. |
|
@lewismc sure thing! |
|
Done! Don't mind the commits, I will squash them at the end. |
| print("Done! downloading the dataset zip .....") | ||
| download_url = subset_response_json['resultURLs'][0] | ||
| if path == '': | ||
| path = os.path.join(os.path.dirname(__file__), 'dataset.zip') |
There was a problem hiding this comment.
Please grab the dataset name correctly from the download_url and append the .zip to this name.
|
@lewismc Done! Apparently I did a silly mistake in my code, it works fine now. Thanks. :) |
| path = path + zip_file_name | ||
| response = urlretrieve(download_url, path) | ||
| zip_content = zipfile.ZipFile(path) | ||
| z.extractall() |
There was a problem hiding this comment.
Veriable Z does not exist yet. Also I wonder if we can create a small unit test? This is looking great BTW @Omkar20895 .
|
oh shoot! pardon me, I don't know what's wrong with me 😅 I will update it with a unit test and everything should be fine then. Thanks. |
1 similar comment
|
+1 Omkar please merge with master. We can release podaacpy 1.5.0 and make the upgrade over in OCW. this is the best functionality yet in podaacpy thank you for working on this. |
|
No problems. Thank you very much! :) |
I tried to remove this error but couldn't I would like to use some fresh perspective. Pardon me if the error was caused by something silly. Ok Thanks. :)
this closes #82