Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixture of Experts Example #109

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Mixture of Experts Example #109

merged 4 commits into from
Oct 16, 2023

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Oct 13, 2023

Created simple mixture of experts example demonstrating that feature

@github-actions
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example looks great and everything runs. Just one small typo

examples/06_Combining_Models.ipynb Outdated Show resolved Hide resolved
Co-authored-by: Katy Jarvis Griffith <55932920+kjjarvis@users.noreply.github.com>
@teubert teubert merged commit 538ce5f into dev Oct 16, 2023
29 checks passed
@teubert teubert deleted the examples/moe branch October 18, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants