Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing Coordinates and degrees as input #140

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Printing Coordinates and degrees as input #140

merged 4 commits into from
Dec 21, 2023

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Dec 20, 2023

Simple PR, adds a string when printing a coordinate.

Shows up like this:

coordinate at 0.6474780571146516°N 1.3331926129490697°W and -0.5999193691200001m elevation

Also, update trajectory and coord to take deg. Updated docs, examples, and tests accordingly

Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (951cdfc) 83.30% compared to head (aee4ff3) 83.29%.

Files Patch % Lines
src/progpy/utils/traj_gen/geometry.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #140      +/-   ##
==========================================
- Coverage   83.30%   83.29%   -0.01%     
==========================================
  Files         100      100              
  Lines       10505    10507       +2     
==========================================
+ Hits         8751     8752       +1     
- Misses       1754     1755       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teubert teubert changed the title Printing Coordinate Printing Coordinates and degrees as input Dec 20, 2023
@teubert teubert merged commit ec48258 into dev Dec 21, 2023
29 of 30 checks passed
@teubert teubert deleted the feature/traj_str branch December 21, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants