Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean handling of events #151

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Clean handling of events #151

merged 1 commit into from
Jul 25, 2024

Conversation

teubert
Copy link
Contributor

@teubert teubert commented Jul 25, 2024

A few changes to cleanup handling of events, including:

  • Allowing a single event to be passed in as a string
  • Input validation
  • Added tests

@teubert teubert linked an issue Jul 25, 2024 that may be closed by this pull request
5 tasks
@teubert teubert self-assigned this Jul 25, 2024
@teubert teubert requested a review from adam-sweet July 25, 2024 00:33
@teubert teubert added component: predictors project: SWS System Wide Safety Project labels Jul 25, 2024
Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

Copy link

@adam-sweet adam-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also changed the prog_server_sws_model.sh script to send just a single event in quotes (not a list) and it worked too.

@teubert teubert merged commit b6b76fa into dev Jul 25, 2024
30 of 31 checks passed
@teubert teubert deleted the feature/clean_events branch July 25, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: predictors project: SWS System Wide Safety Project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

event_strategy for UTP
2 participants