Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query request headers are clobbered by token methods #48

Closed
chuckwondo opened this issue May 11, 2024 · 1 comment · Fixed by #50
Closed

Query request headers are clobbered by token methods #48

chuckwondo opened this issue May 11, 2024 · 1 comment · Fixed by #50
Labels
bug Something isn't working

Comments

@chuckwondo
Copy link
Collaborator

The token and bearer_token methods of the Query class overwrite any headers that might otherwise be set on a query instance. Any methods that add a header should not completely replace all headers.
@chuckwondo
Copy link
Collaborator Author

@frankinspace, please label this as a bug. Also, I submitted a NAMS request to become a maintainer, as you suggested. Did you see the request?

chuckwondo added a commit to chuckwondo/python_cmr that referenced this issue May 13, 2024
@chuckwondo
Fix query header clobbering
593cd29 
Also, export `DayNightFlag` type alias, which was missed when type
annotations were added.

Fixes nasa#48
chuckwondo added a commit to chuckwondo/python_cmr that referenced this issue May 13, 2024
@chuckwondo
Fix query header clobbering.
a78a63f 
Fixes nasa#48
@chuckwondo chuckwondo mentioned this issue May 13, 2024
Merged
chuckwondo added a commit to chuckwondo/python_cmr that referenced this issue May 13, 2024
@chuckwondo
Fix query header clobbering.
3e5b286 
Fixes nasa#48
chuckwondo added a commit to chuckwondo/python_cmr that referenced this issue May 13, 2024
@chuckwondo
Fix query header clobbering.
8949cb7 
Fixes nasa#48
@frankinspace frankinspace added the bug Something isn't working label May 13, 2024
frankinspace added a commit that referenced this issue May 13, 2024
@chuckwondo @frankinspace
Fix query header clobbering. (#50)
f4aab17 
Fixes #48

Co-authored-by: Frank Greguska <89428916+frankinspace@users.noreply.github.com>
@frankinspace frankinspace mentioned this issue Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix query header clobbering chuckwondo/python_cmr
2 participants
@chuckwondo @frankinspace