adding instance_format to variable query #60
Conversation
cmr/queries.py
Outdated
| """ | ||
|
|
||
| if not instance_format: | ||
| return self |
There was a problem hiding this comment.
probably be better to do this instead
if instance_format:
self.params['instance_format'] = instance_format
return self
There was a problem hiding this comment.
agreed, it's a minor difference, but slightly preferred
tests/test_variable.py
Outdated
| @@ -85,3 +85,10 @@ def bearer_test_token(self): | |||
|
|
|||
| self.assertIn("Authorization", query.headers) | |||
| self.assertEqual(query.headers["Authorization"], "Bearer 123TOKEN") | |||
|
|
|||
| def test_archive_center(self): | |||
There was a problem hiding this comment.
| def test_archive_center(self): | |
| def test_instance_format(self): |
cmr/queries.py
Outdated
| """ | ||
|
|
||
| if not instance_format: | ||
| return self |
There was a problem hiding this comment.
agreed, it's a minor difference, but slightly preferred
|
Also please add an entry to the changelog |
|
@briannapagan, do you have time to address the change requests and add the appropriate changelog entry, so we can get this into the next release? |
|
@briannapagan, are you able to address the changes requested on the PR, including adding a changelog entry? There have been a few other PRs merged into the develop branch since you opened this one, so you'll have to get your branch up to date with the develop branch as well. |
briannapagan
force-pushed
the
develop
branch
from
9762d62
to
e702451
Compare
Following the conversation here: #59
NASA GES DISC is releasing public zarr stores for specific variables of collections. The only way to discover what available zarr stores at variable level is via the CMR parameter
instance_format. This simple PR adds this as a search parameter inVariablesQuery.