Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCH_Lab table definition uses CFE_SB_MsgId_t type without including header for it #18

Closed
jphickey opened this issue Oct 23, 2019 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@jphickey
Copy link
Contributor

Describe the bug
All Code compilation units should explicitly #include the headers for all types/macros/functions which are directly used by that unit.

The "sch_lab_sched_tab.h" defines a structure that depends on CFE_SB_MsgId_t, but it does not include the header that provides this type.

To Reproduce
Compilation fails when building with the ic-ccb-20191009 branch, which includes a change that causes the definition of CFE_SB_MsgId_t to no longer be implicitly included.

apps/sch_lab/fsw/platform_inc/sch_lab_sched_tab.h:63:5: error: unknown type name ‘CFE_SB_MsgId_t’
     CFE_SB_MsgId_t  MessageID[SCH_LAB_MAX_SCHEDULE_ENTRIES];  /* Message ID for the table entry */
     ^~~~~~~~~~~~~~

Expected behavior
The build should complete successfully.

System observed on:
Ubuntu 18.04.2 LTS 64 bit (build host)

Reporter Info
Joseph Hickey, Vantage Systems Inc.

@skliper skliper added the bug Something isn't working label Oct 23, 2019
@skliper skliper added this to the 2.4.0 milestone Oct 23, 2019
jphickey added a commit that referenced this issue Oct 23, 2019
Fix #18: Include definition of CFE_SB_MsgId_t

Fast-tracked as part of CCB 2019-10-09 integration
jphickey added a commit that referenced this issue Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants