Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Coding Standard Rules in CodeQL #78

Closed
ArielSAdamsNASA opened this issue May 13, 2021 · 0 comments · Fixed by #79 or #83
Closed

Implement Coding Standard Rules in CodeQL #78

ArielSAdamsNASA opened this issue May 13, 2021 · 0 comments · Fixed by #79 or #83
Assignees
@ArielSAdamsNASA
Labels
continuous-integration

Comments

@ArielSAdamsNASA
Copy link

Is your feature request related to a problem? Please describe.
CodeQL does not use JPL rules, which is used in the upcoming coding standard.

Describe the solution you'd like
Implement JPL rules for CodeQL. Continue using the security queries, but keep them separate from the JPL results. Can use two different workflows, one for the coding standard and one for the security queries.

Describe alternatives you've considered
Might be able to use one workflow, as long as the results can be easily identified as a coding standard issue or security issue.

Additional context
JPL queries are found here: https://github.com/github/codeql/tree/main/cpp/ql/src/JPL_C

Requester Info
Ariel Adams, ASRC Federal
@ArielSAdamsNASA ArielSAdamsNASA self-assigned this May 13, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/sch_lab that referenced this issue May 21, 2021
@arielswalker
Fix nasa#78, Implement Coding Standard CodeQL
84825a8
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/sch_lab that referenced this issue May 21, 2021
@arielswalker
Fix nasa#78, Implement Coding Standard CodeQL
dc9eddb
@ArielSAdamsNASA ArielSAdamsNASA mentioned this issue May 21, 2021
Merged
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/sch_lab that referenced this issue May 26, 2021
@arielswalker
Fix nasa#78, Implement Coding Standard CodeQL
03888d3
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/sch_lab that referenced this issue May 26, 2021
@arielswalker
Fix nasa#78, Implement Coding Standard CodeQL
478b2f6
astrogeco added a commit that referenced this issue Jun 10, 2021
@astrogeco
Merge pull request #79 from ArielSAdamsNASA/fix-78-implement-coding-s…
be52d28 
…tandard-codeql

Fix #78, Implement Coding Standard CodeQL
@astrogeco astrogeco mentioned this issue Jun 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArielSAdamsNASA ArielSAdamsNASA

Labels
continuous-integration
Projects
None yet
Milestone
No milestone
1 participant
@ArielSAdamsNASA