Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registration of events with 0x0000 filters isn't all that helpful #121

Closed
skliper opened this issue Jun 14, 2022 · 0 comments · Fixed by #122
Closed

Registration of events with 0x0000 filters isn't all that helpful #121

skliper opened this issue Jun 14, 2022 · 0 comments · Fixed by #122
Assignees
@skliper
Labels
enhancement New feature or request

Comments

@skliper
Copy link
Contributor

skliper commented Jun 14, 2022

Is your feature request related to a problem? Please describe.
Registration of all events with 0x0000 filters just loads the system without actually filtering anything. Also fills the event filter buffer for the app and likely drops some since default limit is 8.

Describe the solution you'd like
Remove zero entries from initialization and add a filter when/if needed (or operationally via command).

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the enhancement New feature or request label Jun 14, 2022
@skliper skliper self-assigned this Jun 14, 2022
@skliper skliper mentioned this issue Jun 14, 2022
Merged
astrogeco added a commit that referenced this issue Jun 21, 2022
@astrogeco
Merge pull request #122 from skliper/fix121-rm_empty_filters
baa9988 
Fix #121, Remove registration of empty EVS filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #121, Remove registration of empty EVS filters skliper/to_lab
1 participant
@skliper