Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 GIL locking solution #1675

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

excaliburtb
Copy link
Contributor

Implemented use of the python GIL API to replace the less portable mutex solution.

@excaliburtb
Copy link
Contributor Author

i titled it python3 but it still works with 2.7.18 as well

@coveralls
Copy link

coveralls commented Mar 22, 2024

Coverage Status

coverage: 55.86% (-0.05%) from 55.906%
when pulling 499cb1f on excaliburtb:fix_python_gil_locking
into d4f92cc on nasa:master.

@hchen99
Copy link
Contributor

hchen99 commented Mar 26, 2024

Thanks for the fix. According to https://docs.python.org/3/c-api/init.html#non-python-created-threads, for non python created threads, using GIL is the way suggested.

@sharmeye sharmeye merged commit 48924d5 into nasa:master Mar 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants