Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup.py file #26

Merged
merged 3 commits into from
Jul 20, 2021
Merged

Initial setup.py file #26

merged 3 commits into from
Jul 20, 2021

Conversation

gabrieltseng
Copy link
Collaborator

Allows editable pip installs (pip install -e)

@gabrieltseng
Copy link
Collaborator Author

Hmm I thought this would unblock some other stuff, but it doesn't. So I am happy to close this if you had a different vision for the packaging.

Copy link
Contributor

@ivanzvonkov ivanzvonkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrieltseng
Copy link
Collaborator Author

@ivanzvonkov , do you reckon we can delete the requirements.txt since the information is captured in setup.py?

@ivanzvonkov
Copy link
Contributor

Yes, as long as it's straightforward to setup a venv with setup.py.
Maybe this is a good time to add those instructions into the readme?

@gabrieltseng
Copy link
Collaborator Author

Yes, as long as it's straightforward to setup a venv with setup.py.
Maybe this is a good time to add those instructions into the readme?

Cool, added some instructions & we can flesh them out if necessary

@gabrieltseng gabrieltseng merged commit a98f8a5 into main Jul 20, 2021
@gabrieltseng gabrieltseng deleted the package branch July 20, 2021 04:28
ivanzvonkov pushed a commit that referenced this pull request Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants