Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom option to enable italics for comments #83

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Add custom option to enable italics for comments #83

merged 1 commit into from
Jul 13, 2017

Conversation

rafaelrinaldi
Copy link
Contributor

This PR adds an option to enable italics for comments.

Notes

  • By default the new option is disabled (for backwards compatibility)
  • Recommendation is once new option is enabled, comment bg option should be disabled (for better contrast)
  • Add a new comment-light color, for better looking comments once italics are turned on

Screenshots

◉ spacemacs-theme-comment-bg
◯ spacemacs-theme-comment-italic

spacemacs-theme-comment-italic-1

◉ spacemacs-theme-comment-bg
◉ spacemacs-theme-comment-italic

spacemacs-theme-italic-2

◯ spacemacs-theme-comment-bg
◉ spacemacs-theme-comment-italic

spacemacs-theme-italic-3

@nashamri
Copy link
Owner

@rafaelrinaldi Thanks for this! looks pretty good 👍

@nashamri nashamri merged commit 11d6958 into nashamri:master Jul 13, 2017
@rafaelrinaldi rafaelrinaldi deleted the add-italics-in-comments-support branch July 13, 2017 19:33
@nashamri nashamri mentioned this pull request Feb 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelrinaldi @nashamri