Monitor name for some platforms (X11, Wayland and Windows) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may make changes according to this, and I also plan to align the relevant APIs with this library in the future. https://github.com/nashaofu/xcap/blob/master/src/monitor.rs#L33 |
|
I was watching how you did it in that library that by the way I also use it, hahaha, but I wanted to talk about it because forcing that way the name of the monitors doesn't seem right to me, although it is a better alternative to having nothing, I hope the changes I'm proposing will be useful :D |
SergioRibera
force-pushed
the
add_name
branch
from
e4098bd
to
58c1072
Compare
|
By the way, regarding what you mentioned about xcap, I can help you with a refactoring PR for display-info, just let me know and I'll get on it |
nashaofu
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains what is necessary for the
DislpayInfostructure to provide also the name of the monitors that are obtained.At the moment I did not find how to get the display name in mac, so this implementation is pending.
Note
The cost of this implementation is to lose the
Copythat theDisplayInfostructure had.The decision to implement the
from_namefunction in theDisplayInfoimplementation was because it is not a function that requires a different implementation per platform, so a generic function for everyone was sufficient.