Added more stuff #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I get a comment on this? |
|
No problem, I'll submit a pull request as soon as possible. |
|
I resubmitted the original towers & barracks status methods along with their specs. |
|
Could you please name these methods as |
Added tower and rax methods to match.rb fixed typo Added tower & rax methods/specs Redid tower & rax status methods removed reqs
|
Renamed the methods, and tried squashing. Not sure if squashed correctly. |
|
@edchiou thanks, I've squashed it by myself and pushed to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took your suggestion and wrote these methods to return a hash, the keys being tower names and values being :alive and :dead symbols. I could change the keys to be symbol as wells, but I want your feedback on this first.
P.S. Is it possible for you to add a TODO list so I can know what still needs working on?