Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator precedence to parser #27

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Add operator precedence to parser #27

merged 2 commits into from
Feb 23, 2022

Conversation

fenikssc
Copy link
Collaborator

@fenikssc fenikssc commented Feb 23, 2022

…ng tests

@fenikssc fenikssc requested a review from nasso February 23, 2022 19:09
@nasso nasso changed the title Add precedence with basic operator (+, -, *, /) + Add the correspondi… Add operator precedence to parser Feb 23, 2022
@nasso
Copy link
Owner

nasso commented Feb 23, 2022

Looks good so far! I would add a test for an expression like a - b - c to ensure that it corresponds to (a - b) - c

@nasso nasso merged commit bbcba7b into master Feb 23, 2022
@nasso nasso deleted the parser-binop-precedence branch February 23, 2022 20:56
@nasso nasso linked an issue Feb 23, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The parser should respect the precedence of the binary operators
2 participants