Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make binning output consistent #62

Closed
wants to merge 1 commit into from

Conversation

lheinke
Copy link
Contributor

@lheinke lheinke commented May 17, 2022

When binning over an interval that contains zero datapoints in the original data, we get inconsistent output. In such a case, the ynew entry would be NaN while bin_dy would be 0. This is confusing because the error is not zero but unknown, so it should be NaN as well. It was also changed what bin_n gets set to. With this commit it will now be set to 0 which makes more sense since there are zero points and not NaN points in the interval.

@natashabatalha
Copy link
Owner

Merged to dev 01b1fa0 staged for PandExo 2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants