Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NDR intermediate file called without being managed by taskgraph #1426

Closed
dcdenu4 opened this issue Oct 6, 2023 · 0 comments · Fixed by #1427
Closed

NDR intermediate file called without being managed by taskgraph #1426

dcdenu4 opened this issue Oct 6, 2023 · 0 comments · Fixed by #1427
Assignees
@phargogh
Labels
bug Something isn't working critical for issues likely to obstruct the whole dev team (e.g. broken builds) in progress This issue is actively being worked on

Comments

@dcdenu4
Copy link
Member

dcdenu4 commented Oct 6, 2023

An aligned raster is called without waiting for the dependent taskgraph task to complete.

invest/src/natcap/invest/ndr/ndr.py

Lines 610 to 611 in ec4e005

rp_nodata = pygeoprocessing.get_raster_info(
f_reg['aligned_runoff_proxy_path'])['nodata'][0]

This breaks NDR for n_workers > 0
@dcdenu4 dcdenu4 added critical for issues likely to obstruct the whole dev team (e.g. broken builds) bug Something isn't working labels Oct 6, 2023
@phargogh phargogh self-assigned this Oct 6, 2023
@phargogh phargogh added the in progress This issue is actively being worked on label Oct 6, 2023
phargogh added a commit to phargogh/invest that referenced this issue Oct 6, 2023
@phargogh
Joining on the NDR alignment task.
903bdc5 
RE:natcap#1426
phargogh added a commit to phargogh/invest that referenced this issue Oct 6, 2023
@phargogh
Noting second issue addressed in history.
e946ef9 
RE:natcap#1426
@phargogh phargogh mentioned this issue Oct 6, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
bug Something isn't working critical for issues likely to obstruct the whole dev team (e.g. broken builds) in progress This issue is actively being worked on
Projects
None yet
Milestone
No milestone
2 participants
@dcdenu4 @phargogh