Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWY: add results suffix to a few files #1525

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

davemfish
Copy link
Contributor

A few intermediate file outputs were missing the suffix. Based on the variable names, perhaps these files used to be temporary and that's why they didn't get the suffix. But they are no longer temporary.

I also corrected a couple minor bugs in the output spec for this model (intermediate folder not nested within output) and in the carbon model.

Fixes #1517

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@davemfish davemfish requested a review from emlys February 20, 2024 13:50
@davemfish davemfish self-assigned this Feb 20, 2024
Copy link
Member

@emlys emlys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @davemfish!

@emlys emlys merged commit 34bf4f7 into natcap:main Feb 20, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWY model file suffix is missing from a few intermediate files
2 participants