Bugfix/cli 25 newline in log #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phargogh
requested changes
Feb 25, 2020
Yes, good call. I was thinking this change in the logfile was not worth noting for users, but actually the bugfix for loading parameters is very user-facing. Noted in HISTORY and updated PR! |
|
I see that one of the tests is failing, but I'm going to chalk that up to a flaky UI issue and have created #36 so that we remember to address it someday and merge this. Thanks, @davemfish ! |
emlys
added a commit
to emlys/invest
that referenced
this pull request
Apr 18, 2023
3.13.0a9 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the logging from
cli.pyidentical to that frommodel.pywhen a model starts execution. This actually has implications fordatastack.extract_parameters_from_logfile, which expects to find a line starting with "Arguments".