Parentheses on print in Readme. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@natekupp it looks like I need to have a code review for my commits now! I guess this is related to the travis/coveralls stuff. Can you please review, or enable me to review myself, or something?! Thanks. |
|
ha, interesting. I'm not sure how to permit self-reviews, but I'm happy to CR your changes - just tag me in them and I should usually be able to review/respond within 24 hours. I just approved this one |
natekupp
approved these changes
Aug 5, 2017
|
approved, try merging now @jmmcd ? |
|
Thanks! Yes, it's probably better to have a review than a self-review, as ongoing policy. But I don't know what to do next. I don't see a way for me to accept this pull request. (Sorry, I am new to this part of Github.) |
|
Thanks, yes rebase and merge did the right thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.